Skip to content

Fix: Correct engine fixture usage in test_reserved_words#605

Merged
laughingman7743 merged 1 commit intomasterfrom
fix-engine-fixture-usage
Sep 7, 2025
Merged

Fix: Correct engine fixture usage in test_reserved_words#605
laughingman7743 merged 1 commit intomasterfrom
fix-engine-fixture-usage

Conversation

@laughingman7743
Copy link
Member

Summary

Fixes the CI failure introduced in #603 where test_reserved_words was calling engine.dialect on a tuple instead of the engine object.

Problem

The engine fixture returns a tuple (engine, conn), but the test was trying to access engine.dialect directly on the tuple, causing:

AttributeError: 'tuple' object has no attribute 'dialect'

Solution

  • Unpack the engine fixture tuple like other tests do: engine, conn = engine
  • This follows the same pattern used in other tests like test_select_offset_limit

Test Results

  • ✅ Local test passes after the fix
  • ✅ Follows existing code patterns in the test suite

🤖 Generated with Claude Code

The engine fixture returns a tuple (engine, conn), so we need to unpack it
like other tests do. This fixes the CI error where engine.dialect was called
on a tuple instead of the engine object.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@laughingman7743 laughingman7743 marked this pull request as ready for review September 7, 2025 05:53
@laughingman7743 laughingman7743 merged commit 3b1923a into master Sep 7, 2025
19 of 30 checks passed
@laughingman7743 laughingman7743 deleted the fix-engine-fixture-usage branch September 7, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant